Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Uplinks now play a unique 'kaching' sound when purchasing any items. #2686

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1741
Original PR: tgstation/tgstation#82317

About The Pull Request

Syndicate (and others) Uplinks now make a 'kaching' sound whenever the user purchases an item. Only the user will hear the kaching noise as to not give them away. Ever since playing SS14, having no auditory feedback when purchasing ANYTHING over the uplink has perturbed me quite a bit.

Sound here:

kaching.mp4

Why It's Good For The Game

Gives actual (auditory) feedback for whenever a purchase is made. Useful if time dilation goes out-of-wack or if you misclicked on your open uplink and dont know why your TC count dropped. (The latter once happened to me. Don't ask.)

Changelog

🆑 hyperjll
add: Added a 'kaching' sound to the game, and made uplinks play this sound locally to the user whenever a purchase is made.
/:cl:

…y items. (#1741)

* Uplinks now play a unique 'kaching' sound when purchasing any items. (#82317)

## About The Pull Request

Syndicate (and others) Uplinks now make a 'kaching' sound whenever the
user purchases an item. Only the user will hear the kaching noise as to
not give them away. Ever since playing SS14, having no auditory feedback
when purchasing ANYTHING over the uplink has perturbed me quite a bit.

Sound here:


https://github.com/tgstation/tgstation/assets/105099113/bbd518e2-882b-4a12-998d-2b9d00d855bb

## Why It's Good For The Game

Gives actual (auditory) feedback for whenever a purchase is made. Useful
if time dilation goes out-of-wack or if you misclicked on your open
uplink and dont know why your TC count dropped. (The latter once
happened to me. Don't ask.)

## Changelog

:cl:
add: Added a 'kaching' sound to the game, and made uplinks play this
sound locally to the user whenever a purchase is made.
/:cl:

* Uplinks now play a unique 'kaching' sound when purchasing any items.

---------

Co-authored-by: hyperjll <[email protected]>
@ReezeBL ReezeBL merged commit 263a7fd into master Apr 1, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1741 branch April 1, 2024 06:53
AnywayFarus added a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants